Skip to content

Add azuredeploy.json for key-vault-key-create#14739

Open
msmbaldwin wants to merge 1 commit intoAzure:masterfrom
msmbaldwin:akv-restore-key-vault-key-create-json
Open

Add azuredeploy.json for key-vault-key-create#14739
msmbaldwin wants to merge 1 commit intoAzure:masterfrom
msmbaldwin:akv-restore-key-vault-key-create-json

Conversation

@msmbaldwin
Copy link
Copy Markdown
Contributor

Adds azuredeploy.json for the key-vault-key-create sample.

Why?

azuredeploy.json was missing from #14706 under the (incorrect) assumption that CI would regenerate the compiled JSON from main.bicep automatically. AQT doesn't do that — both files are expected to be committed by the contributor, and the "Deploy to Azure" / "Visualize" buttons in README.md link directly to azuredeploy.json.

How was it generated?

az bicep build against the main.bicep already on master.

Re-adds azuredeploy.json (compiled from main.bicep) which was incorrectly removed during the recent RBAC modernization PR. The 'Deploy to Azure' button in README.md links to this file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-quickstarts azure-quickstarts added the remove azuredeploy.json bicep sample, remove json from PR label May 7, 2026
@azure-quickstarts
Copy link
Copy Markdown
Collaborator

@msmbaldwin - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

@msmbaldwin
Copy link
Copy Markdown
Contributor Author

@alex-frankel — quick explanation and ask:

When the four KV RBAC PRs (#14704, #14705, #14706, #14707) were prepared, azuredeploy.json was deleted under the (wrong) assumption that CI would regenerate it from main.bicep. It doesn't, and the "Deploy to Azure" buttons in each README.md link directly to azuredeploy.json — so the merged samples are currently broken.

This PR (and its three siblings #14740, #14741, #14742) just adds the missing azuredeploy.json, generated via az bicep build from the main.bicep already on master. No template logic changes.

MAC is green on all four. The red "Validate" check is the same testResult-required-vs-MAC-schema-rejects-it conflict you merged through on the original PRs. Could you take a look when you have a minute? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remove azuredeploy.json bicep sample, remove json from PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants