Skip to content

refactor: properly gate platform specific code in AutoLaunchBuilder - #35

Merged
zzzgydi merged 4 commits into
zzzgydi:mainfrom
Legend-Master:gate-platform-specific-code
Aug 20, 2026
Merged

zzzgydi merged 4 commits into
zzzgydi:mainfrom
Legend-Master:gate-platform-specific-code

Conversation

@Legend-Master

Copy link
Copy Markdown
Contributor

@zzzgydi

zzzgydi commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Thanks for the PR! The overall direction of gating platform-specific code behind cfg looks good, and moving os_info to a macOS-only dependency makes sense.

However, the branch currently fails to compile on macOS (CI didn't run on this PR, so it went unnoticed). The extracted free function app_name_path has two small issues:

  1. The function body still references self.macos_launch_mode, but a free function has no self (E0424) — it should use the macos_launch_mode parameter instead;
  2. At the call site in build(), self.macos_launch_mode is passed by value to a &MacOSLaunchMode parameter (E0308) — it needs to be &self.macos_launch_mode.

@Legend-Master

Copy link
Copy Markdown
Contributor Author

Hey thanks for the quick response! I'm a bit used to fixing build on different platforms based on the CI since it's a bit easier than testing on multiple devices locally, please trigger the CI again, it should be fixed now.

@zzzgydi
zzzgydi merged commit dc1824a into zzzgydi:main Aug 20, 2026
3 checks passed
@Legend-Master
Legend-Master deleted the gate-platform-specific-code branch August 21, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants