Repository navigation
Fix topo-sort silent drops, action.yml injection, wheel glob - #62
Merged
Merged
Conversation
…heel glob Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
AI review (advisory)Missing tests
Bugs/security No concrete bugs or security issues found in the diff. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
src/cli/plan/topo_sort.rs: operations in a cycle or with an unknowndepends_onid were silently dropped from the apply plan; ordering of independent ops followed HashMap order. Now returns an error (cycle, unknown dep, duplicate id) and keeps plan order. Callers inapply.rsandexecutor_live.rspropagate with?. Added 3 unit tests.action.yml:inputs.handoff/rescue/rescue-user/sbom/versionwere interpolated straight intorun:(script injection); moved toenv:.build_python.sh: wheel globguestkit-*.whl->zyvor_guestkit-*.whl(matches the distribution name in pyproject.toml).Verified
On a Mac mini:
cargo test --lib topo_sort-> 3 passed (debug build). action.yml parses as YAML. Not run: the full test suite, the Action itself,build_python.sh(maturin).Skipped
🤖 Generated with Claude Code