Skip to content

Add artifact build to the CI #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelTimbert merged 5 commits into from
Jun 11, 2026
Merged

Add artifact build to the CI #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5848ec0
Add artifact build to the CI
MichaelTimbert Feb 24, 2026
b488e48
fixing missing .mo files
MichaelTimbert Mar 3, 2026
bb55908
add gettext dependency
MichaelTimbert Mar 3, 2026
90e2ebe
fix sha commit
MichaelTimbert Mar 3, 2026
9c033d6
Documentation: add artifact section
MichaelTimbert Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,38 @@ jobs:
- name: Test
run: |
prove -lv t

build-artifact:
needs: run-tests
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4

- name: apt install
run: sudo apt-get install -y build-essential git libmodule-install-perl gettext

- name: build
run: perl Makefile.PL && make all dist

- name: Get short SHA
id: short_sha
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
echo "SHORT_SHA=$(echo ${{ github.event.pull_request.head.sha }} | cut -c1-7)" >> $GITHUB_ENV
else
echo "SHORT_SHA=$(echo ${{ github.sha }} | cut -c1-7)" >> $GITHUB_ENV
fi

- name: Get Zonemaster-Engine version
id: version
run: |
result=`grep "use version; our $VERSION" lib/Zonemaster/Engine.pm`
result+='printf $VERSION;'
VERSION=`perl -e "$result"`
echo "version=$VERSION" >> $GITHUB_OUTPUT
Comment on lines +125 to +128

@marc-vanderwal marc-vanderwal Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a much cleaner way.

From the source tree’s root, the following one-liner:

perl -Ilib -MZonemaster::Engine -E 'say Zonemaster::Engine->VERSION'

will give the following output:

v8.1.1

(This will load the Zonemaster::Engine module living in the lib subdirectory of the source tree, so this is guaranteed to take the version of the right file.)

@MichaelTimbert MichaelTimbert Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that is much better, but in the build-artefact environnement Zonemaster::LDNS module is not installed, so loading Zonemaster::Engine will failed.


- name: upload artifact
uses: actions/upload-artifact@v4
with:
name: Zonemaster-Engine-${{ steps.version.outputs.version }}-${{ env.SHORT_SHA }}
path: Zonemaster-Engine-${{ steps.version.outputs.version }}.tar.gz
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ read on the [CPAN site].

Documentation on Zonemaster-Engine is also found under the [docs] directory.

## CI artifact

A tarball (`Zonemaster-Engine-<version>.tar.gz`) is built and uploaded as a GitHub Actions artifact on every push and pull request. This artifact can be useful for release testing and PR review.
To download it:
1. Go to the [Actions tab](https://github.com/zonemaster/zonemaster-engine/actions) of the repository.
2. Select a workflow run (e.g. for a specific PR or branch).
3. Scroll to the bottom of the run summary to the **Artifacts** section.
4. Download the artifact named `Zonemaster-Engine-<version>-<short_sha>`.
The artifact name includes the module version and the first 7 characters of the commit SHA.

## Participation, Contact and Bug reporting

Expand Down
Loading