Update data file format#1247
Merged
marc-vanderwal merged 1 commit intoJun 10, 2026
Merged
Conversation
Changes to the cache file format in Zonemaster::Engine require regeneration of some data files in use by the test suite in Zonemaster-Backend. There also was a small mistake in the logic that decides whether to save or restore data from the corresponding data files. Restoration should not be attempted if ZONEMASTER_RECORD=1 is not set in the environment, and likewise, the data files should not be written to if that same variable isn’t in the environment.
marc-vanderwal
requested review from
MichaelTimbert,
matsduf,
mattias-p and
tgreenx
marc-vanderwal
added
P-High
Merged
matsduf
approved these changes
Jun 9, 2026
mattias-p
approved these changes
Jun 9, 2026
matsduf
added
the
V-Patch
Merged
tgreenx
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR regenerates the
t/*.datafiles used in the test suite of Zonemaster-Backend.Context
Follow-up to zonemaster/zonemaster-engine#1517.
Changes
t/*.datafiles in the new CBOR formatZONEMASTER_RECORD=1in the correspondingt/*.tfiles.frKSK because the Internet changedHow to test this PR
Unit tests should pass.