Formal states in tables#1246
Draft
MichaelTimbert wants to merge 11 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce a formal state column to the test_results table, replacing the implicit state inference from the progress integer with explicit, well-defined lifecycle states.
Context
#960
Previously, the state of a test was derived from the progress value (0 = waiting, 1-99 = running, 100 = completed). This made it impossible to distinguish between different terminal states (e.g., completed normally vs. cancelled vs. crashed). This PR adds a proper state column with five formal states.
Changes
Database schema (MySQL, PostgreSQL, SQLite): Added state VARCHAR(20) NOT NULL DEFAULT "waiting" column with a CHECK constraint limiting values to waiting, running, completed, cancelled, crashed.
State constants (DB.pm): Lowercased existing constants (WAITING → waiting, RUNNING → running, COMPLETED → completed) and added two new ones: $TEST_CANCELLED and $TEST_CRASHED.
How to test this PR