You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Travis did not catch that error. t/manifest.t works on the command line. As far as I can see Travis has not run t/manifest.t. Is that because it is in MANIFEST.SKIP and not in MANIFEST? Do Travis and Github actions handle this differently?
Travis did not catch that error. t/manifest.t works on the command line. As far as I can see Travis has not run t/manifest.t. Is that because it is in MANIFEST.SKIP and not in MANIFEST? Do Travis and Github actions handle this differently?
I'm not sure. This was recently added by #1183, we'll need to discuss that again.
Travis did not catch that error. t/manifest.t works on the command line. As far as I can see Travis has not run t/manifest.t. Is that because it is in MANIFEST.SKIP and not in MANIFEST?
I did have a look just now at what Travis is doing, and yes, Travis is skipping tests that are covered by MANIFEST.SKIP. Have a look at the log from https://app.travis-ci.com/github/zonemaster/zonemaster-backend/jobs/628723592#L1285 down to line 1322. I believe this is the directory where make test is executed. AFAICT this is Travis's standard way of dealing with Perl.
Here are those lines quoted:
"/home/travis/perl5/perlbrew/perls/5.38.0/bin/perl" "-Iinc" "-MExtUtils::Manifest=mkmanifest" -e mkmanifest
rm -rf /home/travis/build/zonemaster/zonemaster-backend/build_dir
"/home/travis/perl5/perlbrew/perls/5.38.0/bin/perl" "-Iinc" "-MExtUtils::Manifest=manicopy,maniread" \
-e "manicopy(maniread(),'/home/travis/build/zonemaster/zonemaster-backend/build_dir', 'best');"
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/nb
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/nb/LC_MESSAGES
share/locale/nb/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/inc
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/inc/Module
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/inc/Module/Install
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/es
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/es/LC_MESSAGES
share/locale/es/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster/Backend
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/patch
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/t
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster/Backend/DB
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/script
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/docs
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fr
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fr/LC_MESSAGES
share/locale/fr/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/sv
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/sv/LC_MESSAGES
share/locale/sv/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/da
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/da/LC_MESSAGES
share/locale/da/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/lib/Zonemaster/Backend/Config
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fi
mkdir /home/travis/build/zonemaster/zonemaster-backend/build_dir/share/locale/fi/LC_MESSAGES
share/locale/fi/LC_MESSAGES/Zonemaster-Backend.mo not found at -e line 1.
$ cd /home/travis/build/zonemaster/zonemaster-backend/build_dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-PatchVersioning: The change gives an update of patch in version.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds missing files to manifest which were inadvertently not added by #1192.
Context
#1192
How to test this PR
Unit tests should pass, specifically
t/manifest.t.