Skip to content

fix: correct import in readme - #31

Merged
moven0831 merged 1 commit into
zkmopro:mainfrom
rubydusa:fix-readme-import
Oct 7, 2025
Merged

fix: correct import in readme#31
moven0831 merged 1 commit into
zkmopro:mainfrom
rubydusa:fix-readme-import

Conversation

@rubydusa

@rubydusa rubydusa commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

It seems the function get_ultra_honk_keccak_verification_key was moved from utils to verify

also I suggest adding doctest integration

@moven0831 moven0831 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@moven0831

Copy link
Copy Markdown
Contributor

also, if you plan to use noir-rs through mopro, you can use this APIs for more clean interface

https://zkmopro.org/docs/adapters/noir

@moven0831
moven0831 merged commit 0059db4 into zkmopro:main Oct 7, 2025
3 checks passed
@moven0831 moven0831 mentioned this pull request Oct 7, 2025
6 tasks
Comment thread README.md
Comment on lines +68 to 69
verify::get_ultra_honk_keccak_verification_key,
verify::verify_ultra_honk_keccak,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, found some redundant import statements here, would be great to include the fix in #32

@rubydusa
rubydusa deleted the fix-readme-import branch October 7, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants