chore: pin mopro-ffi path-dep version in mopro-cli for publish#707
Merged
Conversation
`cargo publish -p mopro-cli` requires every dependency to specify a version, including path dependencies (the version is what consumers of the published crate will see; the `path` is stripped on upload). Add `version = "=0.3.6"` alongside the existing `path = "../mopro-ffi"` so we can publish `mopro-cli 0.3.6` to crates.io. No functional change for in-repo builds — path resolution still wins in the workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
version = "=0.3.6"alongside the existingpath = "../mopro-ffi"incli/Cargo.tomlfor themopro-ffidependency.Why
Follow-up to #706. When trying to publish
mopro-cli 0.3.6to crates.io,cargo publishrejects the manifest:For path dependencies, Cargo strips the
path =on upload and substitutes theversion =requirement — so a path dep without a version is publishable only inside the workspace, not to crates.io. Addingversion = "=0.3.6"lets the publishedmopro-cli 0.3.6resolve againstmopro-ffi 0.3.6on crates.io while in-workspace builds still resolve via path.=0.3.6(exact pin) matches what #706 did for themopro inittemplate — the two crates are versioned in lockstep, and an exact pin preventsmopro-cli 0.3.6from accidentally resolving against a futuremopro-ffi 0.3.7that hasn't been validated together.Next step
After this merges:
Test plan
cargo check --workspacestill passes (no behavior change inside workspace).cargo publish -p mopro-cli --dry-runsucceeds on this branch.https://crates.io/crates/mopro-cli/0.3.6exists and listsmopro-ffi =0.3.6as a dep.🤖 Generated with Claude Code