Conversation
la10736
suggested changes
Sep 17, 2025
la10736
left a comment
la10736
left a comment
Contributor
There was a problem hiding this comment.
You should add the benchmark for this new major version.
Beside that LGTM, just some minor comments of something that you inherent from my previous implementation.... sorry
| ]) | ||
| } | ||
|
|
||
| /// Return [V1] with the given map of hash suites. |
Contributor
There was a problem hiding this comment.
I guess is V3 here, isn't it
| self | ||
| } | ||
|
|
||
| /// Return [V1] with the given [SegmentReceiptVerifierParameters] set. |
| self | ||
| } | ||
|
|
||
| /// Return [V1] with the given [SuccinctReceiptVerifierParameters] set. |
Contributor
There was a problem hiding this comment.
See above comment (please check also V2... I guess is wrong too)
| } | ||
|
|
||
| impl V3<circuit::v3_0::CircuitImpl, circuit::v3_0::recursive::CircuitImpl> { | ||
| /// Create an empty [V3] for any risc0 proof generate for any `2.0.x` vm version. |
| } | ||
|
|
||
| fn segment_circuit_info(&self) -> ProtocolInfo { | ||
| ProtocolInfo(*b"RV32IM:v2rev2___") |
Contributor
There was a problem hiding this comment.
This value constant is already in in the circuit module.... why we don't use the constant from the circuit. Can you try if it works? and if it works, can you check also the other contexts?
| } | ||
|
|
||
| fn succinct_circuit_info(&self) -> ProtocolInfo { | ||
| ProtocolInfo(*b"RECURSION:rev1v1") |
| } | ||
|
|
||
| impl V3<circuit::v3_0::CircuitImpl, circuit::v3_0::recursive::CircuitImpl> { | ||
| /// Create an empty [V3] for any risc0 proof generate for any `2.0.x` vm version. |
| ]) | ||
| } | ||
|
|
||
| /// Return [V1] with the given map of hash suites. |
Contributor
There was a problem hiding this comment.
I guess V3 here, can you also check for V2 too... I bet that's is wrong too.
| self | ||
| } | ||
|
|
||
| /// Return [V1] with the given [SegmentReceiptVerifierParameters] set. |
| self | ||
| } | ||
|
|
||
| /// Return [V1] with the given [SuccinctReceiptVerifierParameters] set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.