Skip to content

Preserve entity cleanup and explicit command manufacturers - #834

Draft
dmulcahey wants to merge 1 commit into
devfrom
codex-updated-pr-689
Draft

Preserve entity cleanup and explicit command manufacturers#834
dmulcahey wants to merge 1 commit into
devfrom
codex-updated-pr-689

Conversation

@dmulcahey

@dmulcahey dmulcahey commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

A failing entity removal callback currently aborts the remaining callbacks and task/timer cleanup. Log the failure and continue, preserving each task owner's completion callback.

Device.issue_cluster_command() also accepts manufacturer but drops it before dispatch. Forward an explicitly supplied value in both positional/parameter and server/client command paths, including zero. Omit the keyword when unspecified so zigpy retains manufacturer inference. Tests cover all four dispatch paths, inferred WWAH manufacturer codes, and cleanup after a callback failure.

Supersedes #689. Pending-entity draining and initialization locking were removed from this refresh: #878 addresses reconfiguration's unnecessary activation at its source. This PR has no dependency on #878 and preserves current response-status handling.

Validation against dev at 66603431339afe37fa0048b70ff31d77dceb8f95: Python 3.12 full suite, 1389 passed, coverage above the 95% project gate; full pre-commit (codespell, Ruff, formatting, mypy, lock check) passed. Relevant regression checks fail on the unchanged base. GitHub CI for Python 3.12/3.13/3.14 is reported separately on the PR.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (6660343) to head (ef1ca50).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #834      +/-   ##
==========================================
+ Coverage   97.19%   97.22%   +0.02%     
==========================================
  Files          57       57              
  Lines       10560    10564       +4     
==========================================
+ Hits        10264    10271       +7     
+ Misses        296      293       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmulcahey
dmulcahey force-pushed the codex-updated-pr-689 branch from 80b8570 to ef1ca50 Compare September 5, 2026 19:07
@dmulcahey dmulcahey changed the title Codex updated: Harden device entity lifecycle and command forwarding Preserve entity cleanup and explicit command manufacturers Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant