Preserve entity cleanup and explicit command manufacturers - #834
Draft
dmulcahey wants to merge 1 commit into
Draft
Preserve entity cleanup and explicit command manufacturers#834dmulcahey wants to merge 1 commit into
dmulcahey wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #834 +/- ##
==========================================
+ Coverage 97.19% 97.22% +0.02%
==========================================
Files 57 57
Lines 10560 10564 +4
==========================================
+ Hits 10264 10271 +7
+ Misses 296 293 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dmulcahey
force-pushed
the
codex-updated-pr-689
branch
from
September 5, 2026 19:07
80b8570 to
ef1ca50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failing entity removal callback currently aborts the remaining callbacks and task/timer cleanup. Log the failure and continue, preserving each task owner's completion callback.
Device.issue_cluster_command()also acceptsmanufacturerbut drops it before dispatch. Forward an explicitly supplied value in both positional/parameter and server/client command paths, including zero. Omit the keyword when unspecified so zigpy retains manufacturer inference. Tests cover all four dispatch paths, inferred WWAH manufacturer codes, and cleanup after a callback failure.Supersedes #689. Pending-entity draining and initialization locking were removed from this refresh: #878 addresses reconfiguration's unnecessary activation at its source. This PR has no dependency on #878 and preserves current response-status handling.
Validation against
devat66603431339afe37fa0048b70ff31d77dceb8f95: Python 3.12 full suite, 1389 passed, coverage above the 95% project gate; full pre-commit (codespell, Ruff, formatting, mypy, lock check) passed. Relevant regression checks fail on the unchanged base. GitHub CI for Python 3.12/3.13/3.14 is reported separately on the PR.