Add tuya switch_mode for rotary knobs - #590
Closed
elupus wants to merge 3 commits into
Closed
Conversation
Open
4 tasks
elupus
force-pushed
the
tuya/switch_mode
branch
from
November 30, 2025 03:15
c64b743 to
4d4732d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #590 +/- ##
=======================================
Coverage 96.98% 96.99%
=======================================
Files 63 63
Lines 10559 10573 +14
=======================================
+ Hits 10241 10255 +14
Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elupus
marked this pull request as draft
November 30, 2025 04:07
Contributor
Author
|
Can't get the tests to pass until the quirks have been merged and released. |
elupus
force-pushed
the
tuya/switch_mode
branch
from
November 30, 2025 22:13
83ea548 to
8a69336
Compare
Some weird devices have OnOff clusters with only partial attributes. Tuya remotes are one such device.
elupus
force-pushed
the
tuya/switch_mode
branch
from
November 30, 2025 22:23
8a69336 to
e045063
Compare
elupus
force-pushed
the
tuya/switch_mode
branch
from
December 1, 2025 18:17
e045063 to
57af648
Compare
Contributor
Author
|
Still valid, i will rebase this when we get zigpy/zha-device-handlers#4537 in. |
Contributor
Author
|
This one can be fully done inside quirks as in zigpy/zha-device-handlers#5285 so let's close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add switch mode selection for rotary knobs
Depends on zigpy/zha-device-handlers#4537 to ensure the new select entity shows up.
Contains changes from #591