Add Tuya TS130F variant _TZ3210_jrhczaaa - #5270
Open
clementlamoureux wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #5270 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 424 424
Lines 14667 14670 +3
=======================================
+ Hits 13582 13585 +3
Misses 1085 1085 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new legacy (v1) quirk in zhaquirks/tuya/ts130f.py to match a TS130F curtain/roller-shutter variant that exposes Identify (0x0003), Tuya MCU/manufacturer cluster (0xEF00), and Green Power endpoint 242, ensuring the device uses the custom covering cluster behavior (notably inverted position handling).
Changes:
- Refactors Tuya imports in
ts130f.pyto includeTUYA_CLUSTER_ID. - Adds
TuyaTS130FIdentifyMCUGPwith a signature matching Identify + Tuya MCU cluster + GP endpoint 242. - Defines a replacement cluster set for endpoint 1 using
TuyaWithBacklightOnOffClusterandTuyaCoveringCluster.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+728
to
+732
| Groups.cluster_id, | ||
| Scenes.cluster_id, | ||
| TuyaWithBacklightOnOffCluster, | ||
| TuyaCoveringCluster, | ||
| ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a new quirk
TuyaTS130FIdentifyMCUGPfor aTS130Fcurtain/roller-shutter module variant (seen on_TZ3210_jrhczaaa) whose Zigbee signature is not covered by any of the existingTS130Fquirks inzhaquirks/tuya/ts130f.py.This variant reports, on endpoint 1:
plus the usual Green Power proxy endpoint 242.
Compared to the closest existing quirk (
TuyaTS130GP), this signature additionally exposes the Identify cluster (0x0003) and theTuya MCUcluster (0xEF00), so it fell through without a matching quirk and the covers entity behaved incorrectly (inverted position).Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black