Add support for Candeo RD1P device with v2 firmware - #5268
Open
candeodevelopment wants to merge 4 commits into
Open
Add support for Candeo RD1P device with v2 firmware#5268candeodevelopment wants to merge 4 commits into
candeodevelopment wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #5268 +/- ##
=======================================
Coverage 92.60% 92.61%
=======================================
Files 424 424
Lines 14667 14684 +17
=======================================
+ Hits 13582 13599 +17
Misses 1085 1085 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fix pre-commit errors
Contributor
Author
|
@TheJulianJES any chance of getting this one pushed through please? We're not sure what the needs changes / 2.0 migration needed labels mean, but if there are changes required then please let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds support for newer v2 firmware for the RD1P series of device.
We also moved some shared code back into the device specific file to make future updates simpler. The shared code was an artifact from an earlier PR where each device had a separate file - since this is no longer the case the code no longer needs to be shared.
@TheJulianJES it would be great if this PR can be approved as soon as possible, devices with this new firmware version are due to hit the shelves in the next couple of weeks or so.
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black