Add Bosch Twinguard support - #5250
Open
dehnerson wants to merge 3 commits into
Open
Conversation
Implement the device-specific pairing handshake, measurements, configuration, and alarm controls so Twinguard devices work fully with ZHA. Cover both known manufacturer signatures and protocol behavior with dedicated tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #5250 +/- ##
==========================================
+ Coverage 92.60% 92.66% +0.06%
==========================================
Files 424 425 +1
Lines 14667 14832 +165
==========================================
+ Hits 13582 13744 +162
- Misses 1085 1088 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Keep the custom battery entity grouped consistently with other ZHA battery diagnostics and cover the metadata classification in tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid presenting the VOC-derived estimate as a true carbon-dioxide measurement while retaining its familiar ppm representation and Zigbee2MQTT parity. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add complete Bosch Twinguard (
8750001213, modelChampion) support using the Quirks V2 API.stop,pre_alarm,fire, andburglar) and read-only siren state feedback.Fixes #2561.
Supersedes #3293 with a tested V2 implementation and full alarm/smoke support.
Additional information
The protocol behavior was independently implemented using the Zigbee2MQTT Twinguard implementation as a reference. The quirk has been manually tested with Home Assistant 2026.8.1 and a Connect ZBT-2, including fresh pairing, measurements, configuration controls, self-test, and all alarm modes.
The complete local suite reached 4,846 passed and 2 xfailed; the remaining 8 failures are unrelated Windows-specific failures in existing Inovelli path handling and Tuya timezone/request tests.
Device diagnostics
bosch-twinguard-diagnostics.json
Test plan
pytest tests/test_bosch_twinguard.py tests/test_bosch.py tests/test_quirks_v2.py -q(23 passed)pre-commit run --all-filesChecklist
pre-commitchecks pass / the code has been formatted using Ruff