Convert TS011F plug v2 to QuirkBuilder - #5247
Open
sroeper wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #5247 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 424 424
Lines 14667 14662 -5
=======================================
- Hits 13582 13578 -4
+ Misses 1085 1084 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Convert the existing TS011F plug v2 quirk for
_TZ3000_5f43h46band_TZ3000_okaz9tjsfrom the legacy device definition to QuirkBuilder.The existing Tuya cluster replacements and configuration entities are
preserved:
A unit test was added to verify that the QuirkBuilder definition is
registered for both supported manufacturers and exposes the expected
configuration entities.
Additional information
This is a migration of the existing quirk to QuirkBuilder and is intended
to preserve the existing behavior. No changes to the device functionality
are intended.
The following checks pass:
python -m pytest -q tests/test_tuya_ts011f_plug.py— 2 passedruffruff formatmypycodespellgit diff --checkDevice diagnostics
Not applicable. This PR converts an existing quirk to QuirkBuilder and
does not add support for a new device.
Checklist
pre-commitchecks pass / the code has been formatted using Black