Convert the ZLinky_TIC quirk to v2 and add manufacturer-specific metering attribute definitions

[aauzi]

Proposed change

Add AttributeDefs entries to provide 'default' manufacturer_code for zha_toolkit initiated attribute reads.

Additional information

Fixes #4729

Device diagnostics

Please refer to #4729

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works
• Device diagnostics data has been attached

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (b139f81) to head (cdcaa80).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #4730      +/-   ##
==========================================
- Coverage   92.60%   92.59%   -0.01%     
==========================================
  Files         424      424              
  Lines       14667    14652      -15     
==========================================
- Hits        13582    13567      -15     
  Misses       1085     1085              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TheJulianJES]

These overlap with existing ZCL definitions, right? Can we avoid that and give them another name?
What value is present on the ZCL definitions compared to these?

It might make sense to add quirks v2 entities for this quirk to read the values. I think both the debug UI and ZHA toolkit currently still have some issues with overlapping attribute IDs.

[aauzi]

I agree with the idea of renaming and actually gave it a try without changing the whole quirks into a V2 quirk.
The point is: I get an error if I keep the ZCL attribute definitions unchanged.
The following change though gives good results with both the debug UI and the zha-toolkit scripts.

        # Standard mode: EAIT "Energie active injectée totale" (Production) / Int48 9 car
        # Overwrite: current_summ_received
        # ZCL definition (zigpy-2.0.0)
        # current_summ_received: Final = ZCLAttributeDef(
        #     id=0x0001, type=t.uint48_t, access="r"
        # )
        current_summ_received: Final = ZCLAttributeDef(
            id=0x0001, type=t.uint48_t, access="r", manufacturer_code=LIXEE_MANUFACTURER_CODE
        )
        # Rename according the new definition
        total_active_energy_injected: Final = ZCLAttributeDef(
            id=0x0001, type=t.uint48_t, access="r", manufacturer_code=LIXEE_MANUFACTURER_CODE
        )

        # Standard mode: PTEC "Période tarifaire en cours" / String 4 car
        # Overwrite: active_register_tier_delivered
        # ZCL definition (zigpy-2.0.0)
        # active_register_tier_delivered: Final = ZCLAttributeDef(
        #     id=0x0020, type=RegisteredTier, access="r"
        # )
        active_register_tier_delivered: Final = ZCLAttributeDef(
            id=0x0020, type=t.LimitedCharString(4), access="r", 
            manufacturer_code=0x1037
        )
        # Rename according the new definition
        current_rate_period: Final = ZCLAttributeDef(
            id=0x0020, type=t.LimitedCharString(4), access="r", 
           manufacturer_code=0x1037
        )

Let me know if this looks better.

[Hedda]

I agree with the idea of renaming and actually gave it a try without changing the whole quirks into a V2 quirk.

@aauzi could an alternative idea maybe be to do what @yoda-jm done in #5245 and Convert the ZLinky_TIC quirk to Quirk v2 by extracting it from #4499 which has already contrins a converted ZLinky_TIC quirk to v2, or? See:

• Convert the ZLinky_TIC quirk to v2 and expose tariff period sensors #5245

and

• Migrate almost all v1 quirks to v2 #4499