Adding backend sdl3 + opengl3#44
Merged
Merged
Conversation
hazeycode
approved these changes
May 10, 2025
hazeycode
left a comment
hazeycode
left a comment
Member
There was a problem hiding this comment.
Looks good other than the one comment. Thanks!
| backend_sdl3.newFrame(); | ||
|
|
||
| gui.io.setDisplaySize(@as(f32, @floatFromInt(fb_width)), @as(f32, @floatFromInt(fb_height))); | ||
| gui.io.setDisplayFramebufferScale(1.0, 1.0); |
Member
There was a problem hiding this comment.
I think the order of things here is wrong. But we can come back to it. See the open PR re DPI scaling.
Contributor
Author
There was a problem hiding this comment.
I based this on the sdl2_opengl backend ^^. except that I do the opengl newframe before sdl3 newframe.
I seen that here:
https://github.com/ocornut/imgui/blob/f484af34c2014e98a64410e6cd81e1a5ab434bfd/examples/example_sdl3_opengl3/main.cpp#L162C12-L165C1
But tbh I think the order has no importance as the init before that is in the reverse order.
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed it, so might as well share it.
Hopefully, it's in the required codestyle.
PS: I really like zig-gamedev. Is there any place where we could discuss? irc/discord/forum?