Suppression des apps de ce dépôt - #37
Merged
Merged
Conversation
Design doc only, no implementation. Records the decisions: keep the current state on a live `lts` branch that never merges main, strip apps/ and packages/ui from main, and rewire both production deploys before merging the removal. Co-Authored-By: Claude <noreply@anthropic.com>
Four tasks: create the lts branch, remove apps/, remove packages/ui, prune repo config. Includes the computed catalog prune set (46 entries out, 40 kept) so the pruning step is verifiable rather than eyeballed. Co-Authored-By: Claude <noreply@anthropic.com>
Both apps live on the lts branch now, which also carries the docs deployment workflow. Drops apps/* from the pnpm workspace and the docs#build task from turbo.json.
Its only consumer was apps/simulateurs. The design system stays available on the lts branch.
Drops 46 now-unreferenced catalog entries, and updates README, CONTRIBUTING and .vscode settings to describe a libraries-only monorepo.
The runbook was unexecutable as written: deploy-docs.yml on lts had no manual trigger (fixed there, in a separate commit on lts), and the spec had the github-pages environment authorization after the push that auto-triggers a run doomed to fail the branch-protection check. Reorder the runbook so authorization precedes the push, and extend the Cloudflare step to also restrict branch builds to lts, since Cloudflare would otherwise preview-build every push to main against a deleted apps/simulateurs. Also: document the embed/iframe.ts wire-protocol coupling as a second accepted consequence alongside the API-doc freeze, since main and lts never merge; correct every misattribution of the PILOTE_IR_API_KEY test failures from packages/pilote-ir (no test script) to packages/fiscal, and drop the false "skipped" outcome — there is no skip path, only failure; replace CONTRIBUTING's non-working `pnpm test` step with `pnpm run build && pnpm run ci:test` plus the API key caveat, and restore the still-valid `pnpm dev` mention; note in the README that the linked docs site is now a frozen lts snapshot.
…lt branch A re-review found the docs runbook instructed an unperformable step: it told the operator to click "Run workflow" on the Deploy docs workflow, crediting the workflow_dispatch trigger added on lts. GitHub only renders that button (and only honours the API) for a workflow_dispatch declared on the repository's default branch, which is main — and main's copy of the workflow has no such trigger, plus the runbook itself deletes that file from main. Rewrote the step so the operator verifies the run already triggered by the step-2 push instead, and noted when workflow_dispatch would actually become useful. Also fixed three related inconsistencies: the spec's git diagram still showed lts with one commit instead of the current two, the Cloudflare step's explanatory clause was spliced between the config change and its closing verification actions, and the plan's runbook summary still quoted the old, pre-review step order. Replaced that summary with a pointer to the spec's runbook as the single source of truth so the two docs can't drift again. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.