Repository navigation
vertexfilter: Clamp exponential filter to finite range - #1079
Closed
carrerasdarren-cell wants to merge 1 commit into
Closed
carrerasdarren-cell wants to merge 1 commit into
carrerasdarren-cell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1077.
optlog2(FLT_MAX)returns 128, which does not fit the signed 8-bit exponent stored by the exponential filter. At low mantissa precision this madeoptexp2construct an invalid scale and triggered undefined behavior during float-to-int conversion.Clamp the stored exponent to 127, scale that boundary without relying on denormal handling, and constrain the mantissa to the largest range that still decodes to a finite float. The existing asymmetric
-2^23mantissa remains available at ordinary exponents.The regression covers positive and negative
FLT_MAXin shared-vector mode, checks the exact encoded words, and verifies finite decoded values.Tests:
make -j8 config=sanitize testmake -j8 config=debug testmake -j8 config=release testmake -j8 config=coverage testmake -j8 config=coverage-scalar test