Repository navigation
refactor(graceful): use slices.Backward - #4643
Open
colinaumaty wants to merge 1 commit into
Open
colinaumaty wants to merge 1 commit into
colinaumaty wants to merge 1 commit into
Conversation
Signed-off-by: colinaumaty <colinaumaty@outlook.com>
Author
|
@julianrubino @morde08 Could you please take a look when you have a chance? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
slices.Backwardwhen invoking the graceful process stop stack. This expresses the required LIFO order directly and preserves panic recovery and timeout behavior.How Has This Been Tested?
Note
Low Risk
Behavior-preserving refactor in shutdown ordering only; no change to timeout, panic handling, or stop registration.
Overview
Shutdown stop-stack iteration now uses
slices.Backwardinstead of a manual index loop, so LIFO teardown is expressed directly while keeping the same panic recovery, timeout, and logging aroundShutdownNow.Reviewed by Cursor Bugbot for commit e264263. Configure here.
The PR appears safe to merge.
Summary
The PR replaces the index-based reverse shutdown loop with
slices.Backward.Reviews (1) · Last reviewed commit: "refactor(graceful): use slices.Backward"