ci: add --disable-pip --no-deps --skip-editable to pip-audit - #19
Merged
Conversation
The release-on-tag workflow runs on the hetzner runner image, which does not ship python3.12-venv. Without --disable-pip, pip-audit tries to spin up an internal venv to resolve the requirements file and crashes with: 'The virtual environment was not created successfully because ensurepip is not available.' The CI workflow runs on ubuntu-latest (which has venv) so it never hit this. Adding the flags so the audit works on every runner — the exported requirements are already pinned, so pip-audit doesn't need to resolve anything; it just looks each package up in the OSV database. Same flags the worker SDK already uses for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release-on-tag workflow runs on the hetzner runner image, which does not ship
python3.12-venv. Without--disable-pip,pip-auditfalls back to a pip-based path that tries to spin up an internal venv to resolve the requirements file, and crashes with:The CI workflow runs on
ubuntu-latest(which has venv installed), so it never hit this. Adding the flags so the audit works on every runner — the exported requirements are already pinned with hashes, sopip-auditdoesn't need to resolve anything; it just looks each package up in the OSV database.Same flags the worker SDK already uses for the same reason.
Test plan
make auditruns locally →No known vulnerabilities foundv1.4.0(or bump tov1.4.1) and the release workflow's audit step passes