feat: top-level function for running awaitables in zarr's event loop#3997
Open
d-v-b wants to merge 4 commits into
Open
feat: top-level function for running awaitables in zarr's event loop#3997d-v-b wants to merge 4 commits into
d-v-b wants to merge 4 commits into
Conversation
Contributor
Author
|
@TomNicholas, @aladinor let me know how this looks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
=======================================
Coverage 93.49% 93.50%
=======================================
Files 88 88
Lines 11873 11878 +5
=======================================
+ Hits 11101 11106 +5
Misses 772 772
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following up on #3859 and the discussion in #3835, this PR adds a new top-level function
runfunction that wraps the internalsyncfunction. One notable difference betweenrunandsyncis thatrunraises aRuntimeError(likeasyncio.run) when its invoked in a running loop.While i would still prefer people go through higher-level apis for doing batch IO operations, we haven't gotten around to actually writing those APIs, and users need better perf today.
TODO:
docs/user-guide/*.mdchanges/