feat(viper): support viper configuration for sign/verify#4946
Draft
brandtkeller wants to merge 7 commits into
Draft
feat(viper): support viper configuration for sign/verify#4946brandtkeller wants to merge 7 commits into
brandtkeller wants to merge 7 commits into
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds viper configuration for
zarf package sign|verify.Notably it adds the viper configurations for
verifyunder the root ofpackageinstead ofpackage.verify. This is for a few reasons:package.public_keywhich has always been a root package viper config.package.verifyas a boolean for the enforcement behaviors without creating any breaking changesThere is optionality here and is highly subjective. We could implement
package.verify.*as the placeholder. It follows existing conventions for the commands.verifyis a nuanced command / workflow in that we intend to continue to support its use on all package load operations. The same may not necessarily apply to signing as I believe we can encourage users to implement that in multiple steps.Related Issue
Fixes #4907
Checklist before merging