chore(deps): vendor dependencies#4900
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
|
Slightly off topic, but vendoring is one way cilium secures its CI CD https://cilium.io/blog/2026/05/06/securing-cicd-open-source-lessons-from-cilium/ |
|
Looks like the failures might have been caused by our |
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
minor comments, otherwise good to go
| build | ||
| data/ | ||
| /build | ||
| /data/ |
There was a problem hiding this comment.
| /data/ | |
| /src/test/external/data/ |
The intent of this was for this location to be excluded, we can just set it explicitly
| # Note: the path to the main.go file is not used due to https://github.com/golang/go/issues/51831#issuecomment-1074188363 | ||
| .PHONY: build | ||
| build: ## Build the Zarf CLI for the machines OS and architecture | ||
| go mod tidy |
There was a problem hiding this comment.
Matter of preference, but I like having go mod tidy here so I don't have to remember to run it before I commit. Thoughts on adding back go mod tidy and go mod vendor here as well?
4 participants
Description
Vendor dependencies into the repository, see ZEP-0010 for reasoninig.
Related Issue
Relates to zarf-dev/proposals#10
Checklist before merging