Skip to content

Add appProtocol in zammad-nginx service #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monotek merged 6 commits into from
Apr 8, 2026
Merged

Add appProtocol in zammad-nginx service #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43a6e0e
Add appProtocol in zammad-nginx service
Mar 27, 2026
533eb30
Bump chart version
Mar 27, 2026
97a1696
Merge branch 'main' into main
assi010 Apr 1, 2026
ae6ce7b
Bump chart version
Apr 1, 2026
8e46e82
Merge branch 'main' into main
assi010 Apr 8, 2026
b1217ca
Bump Chart version
assi010 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zammad/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: zammad
version: 16.0.9
version: 16.0.10
appVersion: 7.0.1-0000
description: Zammad is a web based open source helpdesk/customer support system with many features to manage customer communication via several channels like telephone, facebook, twitter, chat and e-mails.
home: https://zammad.org
Expand Down
1 change: 1 addition & 0 deletions zammad/templates/service-nginx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ spec:
targetPort: http
protocol: TCP
name: http
appProtocol: {{ .Values.service.appProtocol }}
Copy link
Copy Markdown
Member

@monotek monotek Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this should go here instead?

https://github.com/zammad/zammad-helm/blob/main/zammad/templates/service-websocket.yaml

Copy link
Copy Markdown
Contributor Author

@assi010 assi010 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought at first as well, but I saw the ingress forwards everything to the zammad-nginx service. The httproute I made follows the same implementation as the ingress, so the only way the gateway can know about the websockets is here.

selector:
{{- include "zammad.selectorLabels" . | nindent 4 }}
app.kubernetes.io/component: zammad-nginx
1 change: 1 addition & 0 deletions zammad/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ image:
service:
type: ClusterIP
port: 8080
appProtocol: kubernetes.io/ws
Copy link
Copy Markdown
Member

@monotek monotek Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have that configurable?

@mgruner
I guess wss (WebSocket Secure) is not available or is this configurable somehow?

Copy link
Copy Markdown
Collaborator

@mgruner mgruner Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean @monotek? The railsserver / web socket server does not handle any TLS termination. This usually happens in the proxy before, e.g. nginx-proxy-manager in Docker stacks.

Copy link
Copy Markdown
Member

@monotek monotek Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it might only make sense to have this configurabel if you also could set:

appProtocol: kubernetes.io/wss


ingress:
enabled: false
Expand Down
Loading