Skip to content

fix: replace mutable default arguments in trainer.py #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace mutable default arguments in trainer.py #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions finetune/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,9 @@ def __get_training_dtype(self) -> torch.dtype:
else:
raise ValueError(f"Invalid mixed precision: {self.args.mixed_precision}")

def __move_components_to_device(self, dtype, ignore_list: List[str] = []):
def __move_components_to_device(self, dtype, ignore_list: List[str] = None):
if ignore_list is None:
ignore_list = []
ignore_list = set(ignore_list)
components = self.components.model_dump()
for name, component in components.items():
Expand All @@ -723,7 +725,9 @@ def __move_components_to_device(self, dtype, ignore_list: List[str] = []):
self.components, name, component.to(self.accelerator.device, dtype=dtype)
)

def __move_components_to_cpu(self, unload_list: List[str] = []):
def __move_components_to_cpu(self, unload_list: List[str] = None):
if unload_list is None:
unload_list = []
unload_list = set(unload_list)
components = self.components.model_dump()
for name, component in components.items():
Expand Down