Skip to content

Fix/zcobol search#838

Draft
Zaneham wants to merge 2 commits into
z390development:mainfrom
Zaneham:fix/zcobol-search
Draft

Fix/zcobol search#838
Zaneham wants to merge 2 commits into
z390development:mainfrom
Zaneham:fix/zcobol-search

Conversation

@Zaneham

@Zaneham Zaneham commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

fixes #825

Ran the NIST test suite on my windows computer and the former failing tests come back as passing.

@Zaneham
Zaneham force-pushed the fix/zcobol-search branch from 89cb7cd to 3fb8c38 Compare June 6, 2026 13:46
@Zaneham

Zaneham commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Some issues with my branches, I'll have to do a cleanup at some point.

@Zaneham
Zaneham marked this pull request as ready for review June 6, 2026 13:51
@Zaneham
Zaneham marked this pull request as draft June 6, 2026 14:01
@Zaneham

Zaneham commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Just an update on where things are at.

Issue Programs Previously reported Current
#818 IC207A, IC208A _END/_INCR undefined, GEN_COMP UNKNOWN LITERAL Clean
#825 NC401M INVALID OPERATOR - IS; _ATEND/_END undefined Clean
#822 NC231A, NC232A, NC234A no base register + _END/_INCR undefined Label cascade resolved; no base register found for the index field (IDXn) still remains
#823 NC233A, NC235A, NC237A, NC238A SEARCH TABLE NOT FOUND - ALL Unchanged, SEARCH ALL (Format 2 binary search) not yet implemented

@abekornelis
abekornelis self-requested a review June 19, 2026 08:59
@Zaneham
Zaneham marked this pull request as ready for review June 19, 2026 12:06
@abekornelis abekornelis added bug Something isn't working component-cobol Related to COBOL support Lang:Macro labels Jun 19, 2026

@abekornelis abekornelis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please combine this fix for #825 with a fix for #822 ?
E.g. NC231A has fewer errors now, but still has L/ST instructions failing for addressability. Maybe use LY/STY instead? Or pre-load R15 with a pointer to the storage area?

@Zaneham
Zaneham marked this pull request as draft July 8, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component-cobol Related to COBOL support Lang:Macro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zCobol SEARCH not generating AT END label

2 participants