investigate failure with np==2.3.0#201
Closed
chrishavlin wants to merge 2 commits intoyt-project:mainfrom
Closed
Conversation
Contributor
Author
|
huh, ok, need to understand more about why decode was being used there in the first place... |
18cf5bb to
1285336
Compare
Contributor
Author
|
with python 3.11 and np 2.3.0: the following call yt_idv/yt_idv/shader_objects.py Lines 170 to 172 in 423ba3e has started return a numpy array for name for some reason. previously, it was a byte string. e.g., for i=0, and np<2.3.0, print((type(name), name, size, gl_type))
<class 'bytes'> b'modelview' 1 35676but upgrading to np==2.3.0 the same line prints to: <class 'numpy.ndarray'> [109 111 100 101 108 118 105 101 119 0 0 0 0 0 0] 1 35676same version of pyopengl in both cases |
Contributor
Author
|
reported upstream at mcfletch/pyopengl#149 |
Contributor
Author
868e3fb to
32dc690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for failing test in #200