Textured planes for slices, cutting planes and projections#14
Open
chrishavlin wants to merge 25 commits intoyt-project:mainfrom
Open
Textured planes for slices, cutting planes and projections#14chrishavlin wants to merge 25 commits intoyt-project:mainfrom
chrishavlin wants to merge 25 commits intoyt-project:mainfrom
Conversation
Member
|
@chrishavlin Could you em |
Contributor
Author
|
just pushed -- had forgotten to run isort and was using a different black version than what the checks here are using. but those should be fixed now! |
Contributor
Author
|
oh and just a note for myself to come back to: I'm not 100% I have the orientation of the resulting planes correct. I need to test out some slices on less symmetrical datasets. |
ce1780d to
927aaa7
Compare
for more information, see https://pre-commit.ci
11e941e to
388bf00
Compare
Contributor
Author
|
reminder to myself when I come back to this next: I don't think the orientation handling going from a FRB to the world coords is currently correct... use slices of the coords to check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more straightforward implementation than #12 (which I will close in favor of this) that adds the ability to add 2d YTDataContainer objects (e.g.,
ds.slice,ds.cutting,ds.proj) to a 3D scene. This implementation generates a frb and uses the data as a 2D texture.Given #13, this is probably most useful for plotting the results of a projection along with a volume rendering:
But there may be some cases where adding independent slices is advantageous. Another example (from
examples/plane_textures_multiple.py) with projections on the bounding-box faces and a slice and cutting plane on the interior:There still seems to be some face culling or z-ordering issue that I haven't figured out yet: when added to an existing volume rendering, planes are not visible from all perspectives (e.g., when running
examples/amr_volume_rendering_with_planes.pyand rotating, planes with disappear/reappear). Adding aGL.glDisable(GL.GL_CULL_FACE)fixes the issue (but I haven't committed that change, as there's probably a better way to fix it).