[WIP] Fix PPVCube#187
Open
jzuhone wants to merge 8 commits intoyt-project:mainfrom
Open
Conversation
…other than gas. allow for non-cell sampling types.
for more information, see https://pre-commit.ci
Member
|
@jzuhone, I've looked this over and it all looks reasonable to me. It sounds like we may try to do a new yt_astro release soon. Should we wait for you to finish the docs so we can include this? |
Member
|
To be fully transparent there are no real blockers if we want to do a release sooner rather than later. The release process is also smooth enough that we can easily cut one when this goes in, regardless of exactly when it happens :) |
Contributor
|
@jzuhone Hi, your ppv branch looks great. I am interested in implementing these changes in my branch as well. I am keen to attempt a rebase. Please let me know if that would be helpful to address the conflicts and close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PPVCubeclass is out of date with both yt and yt_astro_analysis. This PR brings it up to date, in particular:depth_res, which was originally here for off-axis projections and is now long gone in yt."gas".sampling_type="local"in fields to allow for SPH projections.Still need to fix the docs, hence WIP. This appears to have uncovered a bug in yt which I'll have to resolve separately.