Skip to content

Add Django 5 support (without Python 3.12)#283

Merged
marianoeramirez merged 1 commit intoyourlabs:masterfrom
pfouque:dj5
Jan 9, 2024
Merged

Add Django 5 support (without Python 3.12)#283
marianoeramirez merged 1 commit intoyourlabs:masterfrom
pfouque:dj5

Conversation

@pfouque
Copy link
Copy Markdown

@pfouque pfouque commented Oct 30, 2023

Just adding last version of Django to the test matrix and package classifier

The test results are available on my repository: pfouque#1

Reworked to split with #284 (depending on the first to merge we will have to adapt)
(We will have to update the Django 5 version number anyway as soon it's officially released)

@pfouque pfouque marked this pull request as draft October 30, 2023 07:44
@pfouque pfouque marked this pull request as ready for review October 30, 2023 07:48
@pfouque pfouque marked this pull request as draft October 30, 2023 08:46
@marianoeramirez
Copy link
Copy Markdown
Collaborator

Its hard that this work. Because we need to upgrade some dependents librarys like django-dbdiff or get rid of it.

@pfouque
Copy link
Copy Markdown
Author

pfouque commented Oct 31, 2023

Thanks for the tip @marianoeramirez, It will take time a bit more time to investigate if the best way is to find an alternative test method or update django-dbdiff (it has only one usage of the imp module but has not been updated in a while...)

@pfouque
Copy link
Copy Markdown
Author

pfouque commented Nov 6, 2023

Depends on yourlabs/django-dbdiff#21

Copy link
Copy Markdown

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some minor comments.

Copy link
Copy Markdown
Author

@pfouque pfouque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I temporarily added yourlabs/django-dbdiff#21 as the source dependency and it looks fine!
https://github.com/pfouque/django-cities-light/actions/runs/6835469902

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95d2af7) 91.24% compared to head (2646674) 91.24%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          44       44           
  Lines        1794     1794           
=======================================
  Hits         1637     1637           
  Misses        157      157           

@pfouque pfouque marked this pull request as ready for review November 11, 2023 20:33
@pfouque pfouque mentioned this pull request Nov 23, 2023
@pfouque pfouque changed the title Add Django 5 & Python 3.12 support Add Django 5 support (without Python 3.12) Nov 23, 2023
@marianoeramirez
Copy link
Copy Markdown
Collaborator

@pfouque can you update your base branch with last commits?

@marianoeramirez marianoeramirez merged commit e45d984 into yourlabs:master Jan 9, 2024
@pfouque pfouque deleted the dj5 branch January 9, 2024 11:57
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants