Add Django 5 support (without Python 3.12)#283
Merged
marianoeramirez merged 1 commit intoyourlabs:masterfrom Jan 9, 2024
Merged
Add Django 5 support (without Python 3.12)#283marianoeramirez merged 1 commit intoyourlabs:masterfrom
marianoeramirez merged 1 commit intoyourlabs:masterfrom
Conversation
Collaborator
|
Its hard that this work. Because we need to upgrade some dependents librarys like django-dbdiff or get rid of it. |
Author
|
Thanks for the tip @marianoeramirez, It will take time a bit more time to investigate if the best way is to find an alternative test method or update |
Author
|
Depends on yourlabs/django-dbdiff#21 |
pfouque
commented
Nov 11, 2023
Author
pfouque
left a comment
There was a problem hiding this comment.
I temporarily added yourlabs/django-dbdiff#21 as the source dependency and it looks fine!
https://github.com/pfouque/django-cities-light/actions/runs/6835469902
Merged
pfouque
commented
Nov 24, 2023
Collaborator
|
@pfouque can you update your base branch with last commits? |
marianoeramirez
approved these changes
Jan 9, 2024
pfouque
commented
Jan 13, 2024
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding last version of Django to the test matrix and package classifier
The test results are available on my repository: pfouque#1
Reworked to split with #284 (depending on the first to merge we will have to adapt)
(We will have to update the Django 5 version number anyway as soon it's officially released)