Skip to content

Import cities warnings#187

Open
llybin wants to merge 2 commits intoyourlabs:masterfrom
llybin:import_cities_warnings
Open

Import cities warnings#187
llybin wants to merge 2 commits intoyourlabs:masterfrom
llybin:import_cities_warnings

Conversation

@llybin
Copy link
Copy Markdown

@llybin llybin commented Sep 24, 2018

Geonames db contain duplictaes of cities
cities_light has unique key ('region', 'name')
In summary we have integrity errors on saving.

For checking, one of many, can find in cities1000.txt "Bykovo"

570298  Bykovo  Bykovo  Bykovo,Быково   55.63614        38.08027        P       PPL     RU              47                              10700           136     Europe/Moscow   2014-06-30
570300  Bykovo  Bykovo  Bykovo,Быково   55.62075        38.0797 P       PPL     RU              47                              1721            133     Europe/Moscow   2014-07-08

force_insert and force_update were taken out of TRY for static analisator.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 24, 2018

Codecov Report

Merging #187 into master will increase coverage by 0.02%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   94.29%   94.31%   +0.02%     
==========================================
  Files          25       25              
  Lines        1402     1407       +5     
==========================================
+ Hits         1322     1327       +5     
  Misses         80       80
Impacted Files Coverage Δ
cities_light/management/commands/cities_light.py 87.46% <82.35%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b8970...5cc7505. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant