Import cities warnings#187
Open
llybin wants to merge 2 commits intoyourlabs:masterfrom
llybin:import_cities_warnings
Open
Import cities warnings#187llybin wants to merge 2 commits intoyourlabs:masterfrom llybin:import_cities_warnings
llybin wants to merge 2 commits intoyourlabs:masterfrom
llybin:import_cities_warnings
Conversation
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 94.29% 94.31% +0.02%
==========================================
Files 25 25
Lines 1402 1407 +5
==========================================
+ Hits 1322 1327 +5
Misses 80 80
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geonames db contain duplictaes of cities
cities_light has unique key ('region', 'name')
In summary we have integrity errors on saving.
For checking, one of many, can find in cities1000.txt "Bykovo"
force_insert and force_update were taken out of TRY for static analisator.