Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/__tests__/index.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
const rule = require('../').rules;
const RuleTester = require('eslint').RuleTester;

RuleTester.setDefaultConfig({
parser: 'babel-eslint',
var ruleTester = new RuleTester({
parser: require.resolve('@babel/eslint-parser'),
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
requireConfigFile: false,
babelOptions: {
babelrc: false,
configFile: false,
},
},
});

var ruleTester = new RuleTester();

describe('ESLint plugin', () => {
ruleTester.run('no-dynamic-import-moment', rule['no-dynamic-import-moment'], {
valid: ["import('date-fns').then()"],
Expand All @@ -20,7 +23,7 @@ describe('ESLint plugin', () => {
errors: [
{
message: 'Use date-fns or Native Date methods instead of moment.js',
type: 'CallExpression',
type: 'ImportExpression',
},
],
},
Expand All @@ -29,7 +32,7 @@ describe('ESLint plugin', () => {
errors: [
{
message: 'Use date-fns or Native Date methods instead of moment.js',
type: 'CallExpression',
type: 'ImportExpression',
},
],
},
Expand Down
25 changes: 11 additions & 14 deletions lib/rules/no-dynamic-import-moment.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
var message = 'Use date-fns or Native Date methods instead of moment.js';

module.exports = function(context) {
return {
CallExpression: function(node) {
if (node.callee.type !== 'Import') {
return;
}

var arg = node.arguments[0];

if (arg.type === 'Literal' && arg.value === 'moment') {
context.report(node, message);
}
},
};
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
create(context) {
return {
ImportExpression(node) {
if (node.source.type === 'Literal' && node.source.value === 'moment') {
context.report({ node, message });
}
},
};
},
};
40 changes: 22 additions & 18 deletions lib/rules/no-import-moment.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
module.exports = function(context) {
return {
ImportDeclaration: function(node) {
node.specifiers.forEach(function(specifier) {
if (
(specifier.type === 'ImportDefaultSpecifier' ||
specifier.type === 'ImportNamespaceSpecifier') &&
specifier.local.type === 'Identifier' &&
specifier.local.name === 'moment'
) {
context.report(
node,
'Use date-fns or Native Date methods instead of moment.js'
);
}
});
},
};
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
create(context) {
return {
ImportDeclaration(node) {
node.specifiers.forEach((specifier) => {
if (
(specifier.type === 'ImportDefaultSpecifier' ||
specifier.type === 'ImportNamespaceSpecifier') &&
specifier.local.type === 'Identifier' &&
specifier.local.name === 'moment'
) {
context.report({
node,
message:
'Use date-fns or Native Date methods instead of moment.js',
});
}
});
},
};
},
};
37 changes: 20 additions & 17 deletions lib/rules/no-moment-constructor.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
module.exports = function(context) {
return {
CallExpression(node) {
if (node.callee.name === 'moment') {
if (node.arguments.length === 0 || node.arguments.length === 1) {
context.report({
node,
message: `Consider using Native new Date().`,
});
} else {
context.report({
node,
message: `Consider using date-fns, e.g. parse("2010-10-20 4:30", "yyyy-MM-dd H:mm", new Date()).`,
});
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
create(context) {
return {
CallExpression(node) {
if (node.callee.name === 'moment') {
if (node.arguments.length === 0 || node.arguments.length === 1) {
context.report({
node,
message: `Consider using Native new Date().`,
});
} else {
context.report({
node,
message: `Consider using date-fns, e.g. parse("2010-10-20 4:30", "yyyy-MM-dd H:mm", new Date()).`,
});
}
}
}
},
};
},
};
},
};
2 changes: 2 additions & 0 deletions lib/rules/no-moment-methods.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ const rules = require('./methods');
for (const rule in rules) {
const alternative = rules[rule].alternative;
const ruleName = rules[rule].ruleName || kebabCase(rule);

/** @type {import('eslint').Rule.RuleModule} */
module.exports[ruleName] = {
create(context) {
return {
Expand Down
33 changes: 20 additions & 13 deletions lib/rules/no-require-moment.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
module.exports = function(context) {
return {
CallExpression: function(node) {
if (node.callee.type === 'Identifier' && node.callee.name === 'require') {
var arg = node.arguments[0];
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
create(context) {
return {
CallExpression(node) {
if (
node.callee.type === 'Identifier' &&
node.callee.name === 'require'
) {
var arg = node.arguments[0];

if (arg && arg.type === 'Literal' && arg.value === 'moment') {
context.report(
node,
'Use date-fns or Native Date methods instead of moment.js'
);
if (arg && arg.type === 'Literal' && arg.value === 'moment') {
context.report({
node,
message:
'Use date-fns or Native Date methods instead of moment.js',
});
}
}
}
},
};
},
};
},
};
Loading