Skip to content

[codex] fix diagnostic cache key collisions#209

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
yoavbls:mainfrom
Sean-Kenneth-Doherty:codex/cache-diagnostic-symbol-links
Open

[codex] fix diagnostic cache key collisions#209
Sean-Kenneth-Doherty wants to merge 1 commit into
yoavbls:mainfrom
Sean-Kenneth-Doherty:codex/cache-diagnostic-symbol-links

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Contributor

Summary

  • key the hover Markdown cache by diagnostic message, code, range, and related information instead of message alone
  • use the same key for the sidebar HTML cache so symbol links and action ranges stay tied to the correct diagnostic
  • add regression coverage for duplicate messages with different symbol locations and ranges

Fixes #143

Validation

  • npx prettier --write apps/vscode-extension/src/diagnosticCacheKey.ts apps/vscode-extension/src/diagnostics.ts apps/vscode-extension/src/provider/webviewViewProvider.ts apps/vscode-extension/src/test/suite/diagnosticCacheKey.test.ts
  • npm run lint --workspace pretty-ts-errors
  • npm run compile-tests --workspace pretty-ts-errors
  • npx mocha apps/vscode-extension/out/test/suite/diagnosticCacheKey.test.js --ui tdd
  • npm run compile --workspace pretty-ts-errors
  • git diff --check

AI assistance: prepared with OpenAI Codex.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 16, 2026 23:25
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@kevinramharak kevinramharak self-assigned this May 17, 2026
@kevinramharak
Copy link
Copy Markdown
Collaborator

Ill check this one out, I think it solves the issue, just want to check it locally for edge cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

symbol links can point to wrong symbol when error message is a duplicate, but differs in type.

2 participants