Fix/type overload and dom containment - #245
Merged
yoannmoinet merged 2 commits intoMay 13, 2026
Merged
Conversation
…tion
SuperEventType<T> was defined as `${T}${string}` | `${string}${T}`.
While a plain string literal like 'added' is logically assignable to
`added${string}` (via empty suffix), TypeScript's overload resolution
fails to select the correct overload when multiple overloads use similar
broad template literal patterns with 19+ overloads.
Adding T explicitly ensures TypeScript can unambiguously match a plain
event name to the correct overload, inferring the callback data type
without requiring a cast to `any`.
addToDom() and removeFromDom() used document.body.contains() to check whether the joystick element was already in the DOM. This breaks when the zone element is not inside document.body, such as in a Shadow DOM or a detached container (e.g. Angular components with encapsulation). Replace with zone.contains() so the check is scoped to the actual zone where the joystick is managed.
Contributor
Author
|
Please let me know if you need me to split this PR into two or if any other edits need to be made. |
yoannmoinet
approved these changes
May 13, 2026
yoannmoinet
left a comment
yoannmoinet
left a comment
Owner
There was a problem hiding this comment.
Thanks a ton for your PR.
This looks good, no need to split it or anything.
Well done!
Contributor
Author
|
No problem, thanks for merging! |
Owner
|
I'll try and publish it later today. |
Contributor
Author
|
Beautiful, thanks. |
Owner
|
This is now released in |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks so much for the rewrite to TypeScript, it will be much nicer to use now!
Unfortunately when trying to use the new 1.0 release, I came across a few issues:
I built local patches for these and tested these on my production build, but it would of course be preferable to get these issues fixed upstream as well.