Convert IPv4 mapped IPv6 subnet masks to 4 bytes from 16 bytes (using the last 4 bytes)#30
Open
damilola-bello wants to merge 1 commit intoyl2chen:masterfrom
Open
Convert IPv4 mapped IPv6 subnet masks to 4 bytes from 16 bytes (using the last 4 bytes)#30damilola-bello wants to merge 1 commit intoyl2chen:masterfrom
damilola-bello wants to merge 1 commit intoyl2chen:masterfrom
Conversation
… the last 4 bytes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yl2chen
Currently, you can't add IPv4 mapped IPv6 networks.
For example, If you try insert
::ffff:d1ad:35a7/128, a nil network will be inserted. This usesipV4Ranger(as it is stored as IPv4 address internally), but the mask isn't converted and remains 16 bytes. Hence you have something like this209.173.53.167/128instead of209.173.53.167/32.