Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
- Chg #1106: Remove parameters from `PdoConnectionInterface::getActivePdo()` method (@vjik)
- Bug #1109: Fix column definition parsing in cases with brackets and escaped quotes (@vjik)
- New #1107: Add abstract enumeration column type (@vjik)
- Bug #1115: Do not reset `$retryHandler` property on `AbstractCommand::reset()` method call (@Tigrov)

## 1.3.0 March 21, 2024

Expand Down
1 change: 1 addition & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -293,3 +293,4 @@ Each table column has its own class in the `Yiisoft\Db\Schema\Column` namespace
- Change `QueryPartsInterface::withQueries()` parameter to variadic with type `WithQuery`;
- In `DQLQueryBuilderInterface::buildWithQueries()` method change first parameter type form `array[]` to `WithQuery[]`;
- Remove `AbstractCommand::refreshTableSchema()` method;
- Property `$retryHandler` is not reset on `AbstractCommand::reset()` method call;
1 change: 0 additions & 1 deletion src/Command/AbstractCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,6 @@ protected function reset(): void
$this->sql = '';
$this->params = [];
$this->refreshTableName = null;
$this->retryHandler = null;
Comment thread
vjik marked this conversation as resolved.
}

/**
Expand Down
6 changes: 6 additions & 0 deletions tests/Db/Command/CommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,12 @@ public function testSetRetryHandler(): void
$command->setRetryHandler($handler);

$this->assertSame($handler, Assert::getPropertyValue($command, 'retryHandler'));

// Test that setting SQL and raw SQL does not change the retry handler.
$command->setSql('');
$command->setRawSql('');

$this->assertSame($handler, Assert::getPropertyValue($command, 'retryHandler'));
}

public function testTruncateTable(): void
Expand Down