Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… a window (#1865) - The suite is a library (`docxy-suite`, lib `docxy_suite`, `src/lib.rs`) with `run(ext::Extensions)`; the `suite` binary passes none, so the public build is unchanged. - `ext::Extensions::mail` makes a Mail tab's body (`Surface::Ext`, a `TabSurface` view): it has the keys while active, no suite ribbon row is drawn over it, `ext::ShowBackstage` opens File, and the theme's light/dark reaches it. It saves as nothing, as the placeholder did. - A tab chip dragged away from the strip (or out of the window) and let go moves the tab to a new window near the release, through New Window (`tab_tear.rs`, `new_window_at`); a release on the strip still reorders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSDL3miYqxJVj2XRCvBfPf
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSDL3oQAMuX4msSFzPJBq6
yeroo
force-pushed
the
issue-1865-suite-extension-surfaces-tear-off
branch
from
November 4, 2026 14:53
92a0a99 to
0fc697c
Compare
Owner
Author
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1865.
What changed
docxy-suite, libdocxy_suite, withpub fn run(ext::Extensions). Thesuitebinary (src/bin/suite.rs) callsrun(Extensions::default()), so the public build behaves as before.ext.rs).Extensions::mailis an optional factory for a Mail tab's body (Surface::Ext, aTabSurfaceview). While it is active, it has the keys, the suite draws no ribbon row over it, keys it doesn't stop still reach the suite's routing (Ctrl+Tab,Ctrl+W…),ext::ShowBackstageopens File, and the theme's light/dark reaches it. It saves as nothing, as the placeholder did. With no factory, Mail is the placeholder, unchanged.tab_tear.rs). A tab chip dragged more than 36 px above or below the strip (or out of the window) and released moves that tab into a new window near the release, through View › Window › New Window (nownew_window_at). The tab keeps its surface, so its state comes along. A release on the strip still reorders. This works for every tab kind.Tests
tab_tearunit tests for the drop-zone decision.clippy -D warningswas clean, and anxdotooldrag of a tab chip produced a second window while the source kept its other tab. On this machine the patch applies cleanly tomainat 3ca6955, but there is no gpui build environment here, so CI is the build and test check for this push.Not in this PR (follow-ups)
.uitcase for the tear.🤖 Generated with Claude Code
https://claude.ai/code/session_01HSDL3oQAMuX4msSFzPJBq6