Repository navigation
Project gridlines: Current Date line defaults to solid Automatic (#1688) - #1861
Merged
Merged
Conversation
Project 2024 draws a Current Date line on a new plan, but the model's default was none, so a plan without gridlines drew none and a "Current Date: None" could not be stored. The default is now a solid line in the host's colour (Project's green is unmeasured); Status Date, Project Start and Finish stay none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSDL3nzt9KmfLuszLERCMF
Docs no longer claim every default is what the hosts drew before the model; Current Date's default is Project's, and it draws only where the plan's CurrentDate option is set. Note that the default moved without a format marker (an older stored solid Current Date is now dropped on save, a plugin's null now means solid). Test names follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSDL3nzt9KmfLuszLERCMF
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
Author
|
Merged automatically (auto-merge is on for this checkout): review stopped: round 1 had no Major; all findings fixed; merge rounds: none; whole suite on fe5e932 counted as passing (2739 passed, 1 failed: Follow-up: #1862 (draw the Automatic Current Date line in Project's measured green), filed as its own issue. No disputed or deferred review findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1688.
What changed
Line::CurrentDate.default_style()is nowGridline::solid()(Automatic colour) instead of none, so a plan without gridline settings draws a Current Date line wherever itsCurrentDateoption is set, in the suite chart and yppxy, as Project 2024 does. ACurrent Date: Noneis now stored as a real setting and round-trips throughformatting.xml. Status Date, Project Start and Finish stay none.CurrentDate, so existing plans now show the line; a new docxy plan has noCurrentDate, so it draws none until one is set; an older build's stored solid-Automatic Current Date is now the default and is dropped on next save; a plugin'snullfor Current Date now means solid (send{"type":"none"}to turn it off).Tests
nonestored and round-tripped throughformatting.xml; interval test switched to Dotted.gantt/tests.rsand yppxy:a_plan_with_a_current_date_draws_its_line_by_default.cargo test -p projcore -p yppxy,cargo test --bin suite, clippy on projcore/yppxy.Review
revmux round 1: 0 Major, 3 Minor + 2 Immaterial (docs, test names, an assert message), all fixed in fe5e932.
review stopped: round 1 had no Major; all findings fixed
🤖 Generated with Claude Code
https://claude.ai/code/session_01HSDL3oGXV3MLh5XAYGtSLt