Repository navigation
Drop pivot slicer and timeline caches over a removed pivot (#1797) - #1819
Merged
Merged
Conversation
…es slicer names (#1797) remove_pivot notes (sheetId, name); the save strikes caches whose pivots all went, sharing drop_slicer_caches with table slicers. Slicer_/NativeTimeline_ names stay in the model and are left out of Go To. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ArREqgv5wq19er5zSt2H5f
…ides only #N/A cache names (#1797 r1) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ArREqgv5wq19er5zSt2H5f
…its test (#1797 r2) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ArREqgv5wq19er5zSt2H5f
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
Author
|
Merged automatically (auto-merge is on for this checkout): review stopped: round 2 had no Major; all findings fixed, no follow-ups; merge rounds: none; whole suite green on 694bbf0 (workspace tests plus suite workspace: 2692 passed, 0 failures); CI 14 passed; merge-check ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1797
What changed
plan-pivot-slicers): a leak confirmed on main.remove_pivot(directly or throughremove_sheet) notes the pivot's(sheetId, name); the save then drops caches whose everypivotTableentry is removed, with their slicers/timelines, drawing anchors, workbook rel and entry, andSlicer_/NativeTimeline_names. A cache that also filters a surviving pivot only loses the removed entries. The table-slicer dropper is shared (drop_slicer_caches), table behaviour unchanged.remove_pivotkeeps a pivot cache another pivot shares (found in review).plan-model-slicer-names): decided to keepSlicer_names in the model (save takes the package immutably; forgetting at edit time would disturb gridwasm's stash positions). The one host list of names, the suite's Go To, hidesSlicer_*/NativeTimeline_*names whose formula is#N/A.Testing
New gridcore tests (fixtures are synthetic, no Excel oracle) and a suite Go To test;
cargo test --workspaceand the suite workspace on the head.Review record
revmux rounds: 2. Round 1: 1 Major (add_pivot un-noted a removed pivot; fixed), 2 minor and 1 pre-existing (shared cache; all fixed here). Round 2: no Major, 2 minor, fixed.