Repository navigation
CI: give the Linux UI sweep scripts a 300 s timeout (#1785) - #1810
Merged
Merged
Conversation
The slowest scripts take 84-87 s on the runner against a 120 s limit, so a slower day would turn them into timeout ERRORs. The old comment (13 s locally) was stale too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
Author
|
Merged automatically (auto-merge is on for this checkout): review stopped: round 1 had no Major; all findings fixed; merge rounds: none; the sweep-script unit tests (47) passed on e502131 and CI finished 14 passed, 0 failed; merge-check ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1785
The issue's one item (plan-linuxtimeout): on
ui sweep (linux)the slowest scripts take 84-87 s against a 120 s per-script timeout, so a slow runner turns them into timeout ERRORs.--timeout120 -> 300 (Windows uses 420).Tested: ci.yml parses as YAML;
python3 -m unittest discover -s scripts -p 'test_*.py'passes. The real check is this PR'sui sweep (linux).Review: revmux r1 had no Major; its 1 minor and 2 pre-existing comment findings were fixed in this PR.