Skip to content

ci: give the Windows sweep a 1920x1080 screen; drop the entries it fixes (#1779, #1780, #1781, #1782) - #1799

Merged
yeroo merged 4 commits into
mainfrom
issue-1779-windows-ui-sweep-ribbon-groups-c
Oct 25, 2026
Merged

yeroo merged 4 commits into
mainfrom
issue-1779-windows-ui-sweep-ribbon-groups-c

Conversation

@yeroo

@yeroo yeroo commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

What and why

The four #1779 cases did not fail because of Windows font metrics or DPI. The GitHub windows-latest runner's desktop is 1024x768, and Windows caps a window at the screen plus its frame. So every call window-size {"w":1400,…} / {"w":1180,…} came out 1028x780: the sweep artifact of run 40195218119 has 268 captures at 1028x780, while the 640/700/460-wide requests are exact. At 1028 px the sheet Formulas tab collapses Formula Auditing, Home collapses Cells/Editing, and the Project Task tab collapses group 4, which are the four failing assertions. The cases are right at the sizes they ask for (Linux passes them).

Closes #1779
Closes #1780
Closes #1781
Closes #1782

Testing

Review

One revmux round (Claude-only profile, 4 reviewers): 0 Major, 1 Minor and 2 Immaterial, all fixed in 73c222b. SetProcessDpiAwarenessContext is now declared bool and its result is printed. The guard also checks the logical screen size at the runner's DPI (≥ 1410x815). The docs and the comment say what is checked.

review stopped: round 1 had no Major; all findings fixed

Follow-up: #1800 (window-size should report the size the window actually got, so a clamp shows in the transcript).

🤖 Generated with Claude Code

https://claude.ai/code/session_01MGUtabxdbfDq8UMHBxPDk3

…#1779)

The windows-latest desktop is 1024x768 and Windows caps a window at the
screen plus its frame, so every `window-size` wider than that came out
1028x780 and the ribbon cases fitted a narrower ribbon than they asked for.
A step before the sweep sets the display with ChangeDisplaySettings, reads
the mode back (not Screen.Bounds, which a DPI-unaware pwsh scales) and fails
the job, listing the modes offered, if it is still below 1920x1080.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rv2fT85ZVexcbhT7EDF6hZ
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

The cases ask for logical pixels, so a 1920x1080 mode at a large scale could
still clamp a 1400x800 window. The step now prints whether setting DPI
awareness took (it returns BOOL, not a context), the system DPI and the
logical size, and fails below 1410x815 logical as well as below 1920x1080.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rv2fT85ZVexcbhT7EDF6hZ
yeroo and others added 2 commits October 25, 2026 19:42
The PR's Windows sweep (run 40209311321) passed the #1780 Project table and
Timeline cases, #1781 page-line-numbers and #1782 style-gallery once the
window got the size it asked for, so the sweep refused them as unexpected
passes. Same clamp, same fix.

Closes #1780, #1781, #1782 with this change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rv2fT85ZVexcbhT7EDF6hZ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rv2fT85ZVexcbhT7EDF6hZ
@yeroo yeroo changed the title ci: give the Windows sweep a 1920x1080 screen; drop the #1779 entries ci: give the Windows sweep a 1920x1080 screen; drop the entries it fixes (#1779, #1780, #1781, #1782) Oct 25, 2026
@yeroo
yeroo merged commit 96a3c67 into main Oct 25, 2026
14 checks passed
@yeroo
yeroo deleted the issue-1779-windows-ui-sweep-ribbon-groups-c branch October 25, 2026 17:20
@yeroo

yeroo commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Merged automatically (auto-merge is on for this checkout): review stopped: round 1 had no Major; all findings fixed; merge rounds: none; whole suite green on 00079bb (CI 14/14 checks: Windows UI sweep 142 scripts, 140 pass, 2 xfail, 0 fail, 0 xpass; Linux UI sweep 141 pass, 1 xfail); merge-check ok.

Follow-ups: #1800 (separate issue: window-size should report the size the window actually got). No finding was deferred or disputed.

Also closes #1780, #1781 and #1782. They had the same 1028x780 clamp, and their entries came out as unexpected passes on this PR's first sweep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants