fix(engine): graceful shutdown on duration expiry and clarify error log - #30
Merged
Conversation
- single.go: rename interval debug log from "First error encountered" to "Error sample" to reflect per-interval reset semantics - stateful.go: preserve original ctx as httpCtx before WithTimeout is applied so HTTP requests are not bound to the duration deadline - stateful.go: change reqCtx from ctx to httpCtx so in-flight HTTP requests complete naturally when test duration expires instead of being forcibly cancelled with "context deadline exceeded" - stateful.go: change result-send selects (main HTTP result, failRes) to use httpCtx.Done() so results from in-flight requests are recorded in .bin even after duration timeout fires; only an explicit Stop Test cancels httpCtx and drops results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to "Error sample" to reflect per-interval reset semantics
applied so HTTP requests are not bound to the duration deadline
requests complete naturally when test duration expires instead of
being forcibly cancelled with "context deadline exceeded"
to use httpCtx.Done() so results from in-flight requests are
recorded in .bin even after duration timeout fires; only an
explicit Stop Test cancels httpCtx and drops results