Web 1146 shared helpers#90
Draft
irmkr wants to merge 3 commits into
Draft
Conversation
irmkr
force-pushed
the
WEB-1146-shared-helpers
branch
from
1b14259 to
1b4ca80
Compare
matthias-reis
suggested changes
Aug 2, 2021
| import { logger } from '../../helpers/logger'; | ||
|
|
||
| import { getReleasablePackages } from '../../helpers/get-releasable-packages'; | ||
| import { missingEnvAttrError } from '../../helpers/validation-errors'; |
Contributor
There was a problem hiding this comment.
You could implement this inside helpers/logger. There you already have the topic. Makes the API much simpler.
Contributor
There was a problem hiding this comment.
I'd also name it throwMissingAttrError. Makes it more clear, that we throw an error inside.
| import { getReleasablePackages } from '../../helpers/get-releasable-packages'; | ||
| import { missingEnvAttrError } from '../../helpers/validation-errors'; | ||
|
|
||
| const topic = '[analyse] adapt dependencies'; |
Contributor
There was a problem hiding this comment.
Then you also don't have to extract topic.
irmkr
force-pushed
the
WEB-1146-shared-helpers
branch
from
1b4ca80 to
9fd08a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.