Add XCP-ng 9.0 in the report#792
Open
glehmann wants to merge 1 commit intogln/koji-build-cache-qtkzfrom
Open
Conversation
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/report-xcp-ng-9-tspp
branch
from
f9e6075 to
a25aa19
Compare
ydirson
reviewed
Mar 12, 2026
Comment on lines
-200
to
+202
| return TAG_ORDER.index(tag) | ||
| if tag in TAG_ORDER: | ||
| return TAG_ORDER.index(tag) | ||
| else: | ||
| return -1 |
Contributor
There was a problem hiding this comment.
How is that related to v9.0-incoming?
BTW, looking at that code, I think find_previous_build_commit could avoid relying on hardcoded lists, and use koji list-tag-inheritance to get the actual relation to the tags it inherits from
Member
Author
There was a problem hiding this comment.
How is that related to
v9.0-incoming?
This function is used with the tag almalinux-10.0, which I think comes from the previous task that imported the packages.
BTW, looking at that code, I think
find_previous_build_commitcould avoid relying on hardcoded lists, and usekoji list-tag-inheritanceto get the actual relation to the tags it inherits from
I don't think find_previous_build_commit is using a hardcoded list. Could you elaborate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.