python project configuration for koji scripts#733
Conversation
glehmann
force-pushed
the
gln/koji-build-script-rvln
branch
from
13a2b2e to
9a30b4e
Compare
|
Does this incur a change for current users of the |
ydirson
left a comment
ydirson
left a comment
There was a problem hiding this comment.
The info in the commit message would be useful in a README, and maybe uvx can be suggested for install?
Currently it only display a warning about the file location that has been changed. But that's not mandatory. |
| @@ -0,0 +1 @@ | |||
| 3.11.11 | |||
There was a problem hiding this comment.
What's the point of this file? This version can't be enforced (my system doesn't provide it)
There was a problem hiding this comment.
uv uses it to pin the python version
There was a problem hiding this comment.
What's the point of this file? This version can't be enforced (my system doesn't provide it.
uv should install that exact version for you. That's not the case?
There was a problem hiding this comment.
I install tools using uv tool, I've never seen it installing python version.
There was a problem hiding this comment.
Feels strange, as https://docs.astral.sh/uv/guides/tools/ says uv tool run is the same as uvx, and
Tools are installed into temporary, isolated environments when using uvx.
There was a problem hiding this comment.
If the system python matches the version allowed in pyproject.toml, I don't see why it would be strange to use the system interpreter
glehmann
force-pushed
the
gln/koji-build-script-rvln
branch
2 times, most recently
from
0d39503 to
7427a6a
Compare
glehmann
force-pushed
the
gln/koji-build-script-rvln
branch
2 times, most recently
from
f9405d1 to
9ae3dc1
Compare
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/koji-build-script-rvln
branch
from
9ae3dc1 to
c16a69e
Compare
|
I removed myself from the reviewers. There are two approvals, looks like it can be rebased and then merged. |
4 participants
We can now
uv syncin the dir, andexport PATH=$PWD/.venv/bin:$PATHto usekoji-buildwith its required dependency.The package should also be publishable, allowing, in the future, to
pipx install koji-utilsto havekoji-buildand the other tools available in the shell.Note that I had to move
koji_build.pyto a module directory. The rootkoji_build.pynow prints a warning saying it's been moved, but we could also not print any warning.