Close branch rows and handle iteration errors in DeleteProject - #11
Open
kojah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteProjectreturnsErrProjectNotEmptybefore installingdefer branches.Close(), which leaks the rows on that path. It also does not checkbranches.Err(), so an iteration error can allow deletion to continue as if the project were empty.This PR moves the defer before the early return and surfaces iteration errors. It also closes each env file per iteration in
envcfginstead of deferring closure until the function returns.Testing:
go test -race ./internal/envcfgpasses.go test -run '^$' ./services/projects/store/sqlstorepassesI found these issues through a static analysis tool I'm developing called gohawk. If you're interested, let me know and I can open a separate PR to add gohawk to your linter configuration :) You can view more comprehensive information about the project on the documentation website: https://gohawk.dev