Skip to content

Use an impossible PID in the pidfile unit test to prevent flakiness #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewkroh wants to merge 1 commit into
base: release-1.28
Choose a base branch
from
Open

Use an impossible PID in the pidfile unit test to prevent flakiness #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/management/postgres/pidfile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,16 @@ var _ = Describe("the detection of a postmaster process using the pid file", fun
instance.PgData = pgdata
instance.SocketDirectory = socketDir

// Use a PID that is guaranteed not to exist on any system.
// The Linux kernel pid_max is at most 4194304 (2^22),
// so 5000000 is safely above any possible real PID and
// well within the range of a 32-bit int.
pidFile := filepath.Join(pgdata, PostgresqlPidFile)
err := os.WriteFile(pidFile, []byte("1234"), 0o400)
err := os.WriteFile(pidFile, []byte("5000000"), 0o400)
Expect(err).ShouldNot(HaveOccurred())

lockFile := filepath.Join(socketDir, PostgresqlPidFile)
err = os.WriteFile(filepath.Join(socketDir, ".s.PGSQL.5432.lock"), []byte("1234"), 0o400)
err = os.WriteFile(filepath.Join(socketDir, ".s.PGSQL.5432.lock"), []byte("5000000"), 0o400)
Expect(err).ShouldNot(HaveOccurred())

process, err := instance.CheckForExistingPostmaster(GetPostgresExecutableName())
Expand Down
Loading