Repository navigation
Initialize new backup repositories before use - #122
Merged
Merged
Conversation
A bucket or repository path change can retain the stanza name. The manager then mistakes initialization of the old repository for readiness of the new one. Backups only poll for stanza metadata and can time out before WAL archiving triggers recovery. Initialization must follow configuration changes and remain pending after failure, even when the next reconcile finds the file unchanged. Replicas and suspended clusters must defer initialization until they become eligible.
The fake pgBackRest command must be executable, and its output is read from a test-owned temporary directory. Document these narrow gosec exceptions so CI accepts the fixture without disabling security checks for other code. Keep imports in the configured gci groups.
andrew-farries
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bucket or repository path change can retain the stanza name. The
manager then mistakes initialization of the old repository for readiness
of the new one. Backups only poll for stanza metadata and can time out
before WAL archiving triggers recovery.
Initialization must follow configuration changes and remain pending
after failure, even when the next reconcile finds the file unchanged.
Replicas and suspended clusters must defer initialization until they
become eligible.